WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#35741 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/includes/class-wp-filesystem-ssh2.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (2)

35741.patch (717 bytes) - added by ramiy 20 months ago.
35741.2.patch (801 bytes) - added by ramiy 20 months ago.
Add translators comment

Download all attachments as: .zip

Change History (10)

@ramiy
20 months ago

#1 @ramiy
20 months ago

  • Keywords has-patch added

#2 @ocean90
20 months ago

  • Keywords needs-patch added; has-patch removed

A translators comment is missing.

@ramiy
20 months ago

Add translators comment

#3 @ramiy
20 months ago

Old string:

  • The ssh2 PHP extension is available, however, we require the PHP5 function <code>stream_get_contents()</code>

New string:

  • The ssh2 PHP extension is available, however, we require the PHP5 function %s

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


19 months ago

#5 follow-up: @ramiy
19 months ago

Should we add a period at the end of the sentence?

#6 in reply to: ↑ 5 @SergeyBiryukov
19 months ago

Replying to ramiy:

Should we add a period at the end of the sentence?

Other strings don't have it, maybe it's added on output though (haven't tested yet). If the period is indeed missing, let's add it for all these strings at once in a separate ticket.

#7 @SergeyBiryukov
19 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36670:

I18N: Remove <code> tag from translatable string in wp-admin/includes/class-wp-filesystem-ssh2.php.

Props ramiy.
Fixes #35741.

#8 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.