WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#35743 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/upload.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (1)

35743.patch (613 bytes) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (7)

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Keywords has-patch added

#2 @ramiy
5 years ago

Old string:

  • The grid view for the Media Library requires JavaScript. <a href="upload.php?mode=list">Switch to the list view</a>.

New strings:

  • The grid view for the Media Library requires JavaScript. %s.
  • Switch to the list view

#3 follow-up: @SergeyBiryukov
5 years ago

It's easy to forget or accidentally remove %s at the end. Let's just change upload.php?mode=list to a placeholder.

#4 in reply to: ↑ 3 @ramiy
5 years ago

Replying to SergeyBiryukov:

It's easy to forget or accidentally remove %s at the end. Let's just change upload.php?mode=list to a placeholder.

Ok.

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36668:

I18N: Replace hardcoded URL in a translatable string with a placeholder in wp-admin/upload.php.

Props ramiy.
Fixes #35743.

#6 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.