WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 21 months ago

Last modified 21 months ago

#35745 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/themes.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (1)

35745.patch (1.3 KB) - added by ramiy 22 months ago.

Download all attachments as: .zip

Change History (6)

@ramiy
22 months ago

#1 @ramiy
22 months ago

  • Keywords has-patch added

#2 @ramiy
22 months ago

Old strings:

  • Settings saved and theme activated. <a href="%s">Visit site</a>
  • New theme activated. <a href="%s">Visit site</a>

New strings:

  • Settings saved and theme activated.
  • New theme activated.
  • Visit site

No HTML tags, much easier to translate.

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


22 months ago

#4 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36657:

I18N: Remove <a> tags from translatable strings in wp-admin/themes.php.

Props ramiy.
Fixes #35745.

#5 @jorbin
21 months ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.