WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#35751 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/includes/meta-boxes.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: low
Severity: normal Version:
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

See the attached patch.

Attachments (3)

35751.patch (986 bytes) - added by ramiy 6 years ago.
35751.2.patch (4.3 KB) - added by ramiy 6 years ago.
few more translation strings
35751.3.patch (2.3 KB) - added by ramiy 6 years ago.
only the codex links…

Download all attachments as: .zip

Change History (14)

@ramiy
6 years ago

@ramiy
6 years ago

few more translation strings

#1 @ramiy
6 years ago

  • Keywords has-patch added

#2 @ramiy
6 years ago

Old string:

  • Excerpts are optional hand-crafted summaries of your content that can be used in your theme. <a href="https://codex.wordpress.org/Excerpt" target="_blank">Learn more about manual excerpts.</a>

New strings:

  • Excerpts are optional hand-crafted summaries of your content that can be used in your theme.
  • https://codex.wordpress.org/Excerpt
  • Learn more about manual excerpts.

Old string:

  • Trackbacks are a way to notify legacy blog systems that you&#8217;ve linked to them. If you link other WordPress sites, they&#8217;ll be notified automatically using <a href="https://codex.wordpress.org/Introduction_to_Blogging#Managing_Comments" target="_blank">pingbacks</a>, no other action necessary.

New strings:

  • Trackbacks are a way to notify legacy blog systems that you&#8217;ve linked to them. If you link other WordPress sites, they&#8217;ll be notified automatically using <a href="%s" target="_blank">pingbacks</a>, no other action necessary.
  • https://codex.wordpress.org/Introduction_to_Blogging#Managing_Comments

Old string:

  • Custom fields can be used to add extra metadata to a post that you can <a href="https://codex.wordpress.org/Using_Custom_Fields" target="_blank">use in your theme</a>.

New strings:

  • Custom fields can be used to add extra metadata to a post that you can <a href="%s" target="_blank">use in your theme</a>.
  • https://codex.wordpress.org/Using_Custom_Fields

Old string:

  • Allow <a href="%s" target="_blank">trackbacks and pingbacks</a> on this page.

New strings:

  • Allow %s on this page.
  • trackbacks and pingbacks

Old string:

  • If the link is to a person, you can specify your relationship with them using the above form. If you would like to learn more about the idea check out <a href="http://gmpg.org/xfn/">XFN</a>.

New strings:

  • If the link is to a person, you can specify your relationship with them using the above form. If you would like to learn more about the idea check out %s.

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


6 years ago

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.5
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @ramiy
6 years ago

You don't have to accept all the changes... and It would be better if you do a separate commit for each string. This way It won't be all-or-nothing package deal.

#6 follow-up: @ocean90
6 years ago

  • Priority changed from normal to low

I really don't think that any of them are worth to change. But if we really want to change something then I'd only split the codex links in the following three strings:

Excerpts are optional hand-crafted summaries of your content that can be used in your theme. <a href="https://codex.wordpress.org/Excerpt" target="_blank">Learn more about manual excerpts.</a>

Excerpts are optional hand-crafted summaries of your content that can be used in your theme. <a href="%s" target="_blank">Learn more about manual excerpts.</a>'


Trackbacks are a way to notify legacy blog systems that you&#8217;ve linked to them. If you link other WordPress sites, they&#8217;ll be notified automatically using <a href="https://codex.wordpress.org/Introduction_to_Blogging#Managing_Comments" target="_blank">pingbacks</a>, no other action necessary.

Trackbacks are a way to notify legacy blog systems that you&#8217;ve linked to them. If you link other WordPress sites, they&#8217;ll be notified automatically using <a href="%s" target="_blank">pingbacks</a>, no other action necessary.


Custom fields can be used to add extra metadata to a post that you can <a href="https://codex.wordpress.org/Using_Custom_Fields" target="_blank">use in your theme</a>.

Custom fields can be used to add extra metadata to a post that you can <a href="%s" target="_blank">use in your theme</a>.

@ramiy
6 years ago

only the codex links...

#7 in reply to: ↑ 6 @ramiy
6 years ago

Replying to ocean90:

if we really want to change something then I'd only split the codex links

Done in the 3rd patch. Replacing the codex links with %s placeholder.

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


6 years ago

#9 @chriscct7
6 years ago

  • Keywords commit added

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


6 years ago

#11 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37016:

I18N: Move translatable Codex URLs to separate strings in wp-admin/includes/meta-boxes.php.

Props ramiy.
Fixes #35751.

Note: See TracTickets for help on using tickets.