WordPress admin <title> structure

[ramiy]

Currently the admin titles has a wired structure. Few examples:

• Dashboard ‹ Site Name — WordPress
• Posts ‹ Site Name — WordPress
• Writing Settings ‹ Site Name — WordPress

Same structure applies for plugin setting pages.

• page-title ‹ site-name — WordPress

The problem with this structure:

• Why are we using ‹ character? why not ›.
• We should add RTL support for the separator.
• The Site Name and the WordPress, they look like bad combination.

Few suggestions:

• We need to replace the ‹ character with ›.
• We can add RTL support. See ticket #35737 and changeset [36487].
• And we need to think about the combination of WordPress and Site Name.

[ramiy]

Replace ‹ with — and remove — WordPress

[ramiy]

New title structure page-title separator site-name

[ramiy]

In the second option, I use a similar structure to the login pages (ticket #35737), without the WordPress suffix. Only when no site-title defined (multisite), we use WordPress.

Old structure:

if ( $admin_title == $title )
	$admin_title = sprintf( __( '%1$s — WordPress' ), $title );
else
	$admin_title = sprintf( __( '%1$s ‹ %2$s — WordPress' ), $title, $admin_title );

New structure:

if ( $admin_title == $title )
	$admin_title = sprintf( '%1$s %2$s %3$s', $title, $separator, __( 'WordPress' ) );
else
	$admin_title = sprintf( '%1$s %2$s %3$s', $title, $separator, $admin_title );

Hoping to create more consistent <title> structure across different wordpress pages.

[ramiy]

separator with RTL support - $separator = is_rtl() ? '›' : '‹';

[SergeyBiryukov]

I think ‹ (in Dashboard ‹ Site Name) implies hierarchy, Dashboard › Site Name would seem confusing to me.

That said, we could probably use — instead and simplify it to Dashboard — Site Name (without the WordPress suffix), like in ​#meta1105.

35774-option1.patch​ looks good to me, but we should also add translator comments for placeholders.

[ramiy]

@SergeyBiryukov, I was talking to @adamsilverstein on slack,

Currently, the admin 'separator' char is hardcoded. The attached patch (35774-option2.patch​ and 35774-option3.patch​) moves the 'separator' into a string.

Ticket #35737 moved the 'separator' into a string for Login Pages. This ticket will do the same for Admin Pages.

The next step is to create a filter for the 'separator'. The filter will be used in admin page and login pages for unified title structure.

[ramiy]

And I remember ​what I wrote on the meta ticket. Direction-free separator like — is much better than ›. But I didn't want to rock the boat too much.

[ramiy]

@SergeyBiryukov @chriscct7 @ocean90 Maybe in 4.7?

[jorbin]

The patch needs translator comments.

[ramiy]

Replying to jorbin:

The patch needs translator comments.

We don't need translator-comments. The patch removes translatable-strings. The placeholders '%1$s %2$s %3$s' are part of the sprintf() function, they are not a translatable strings.

[jorbin]

@SergeyBiryukov You milestoned this, still want it to go in for this cycle?

[ocean90]

IMO the current title is fine as is. It's fully translatable which means placeholders can be set as needed.

[whyisjake]

I like the 35774-option2.patch that would use an emdash over needing to be concerned with RTL settings.

[ocean90]

Moving to next major milestone since it isn't a regression.

[davidbaumwald]

This ticket still needs a decision on implementation and the patches need refreshing. With version 5.3 Beta 1 going out tomorrow, I'm moving this to Future Release.