WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#35826 closed enhancement (fixed)

Customizer: Contain "No Image Set" in dashed border

Reported by: melchoyce Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

In the Customizer, in panels like Site Identity, Header Image, and Background Image, the "no image set" label seems to just float there. We should add a dashed border to that container div so it looks grounded.

See attached images for before/after.

Attachments (5)

no-image-set-before.png (492.8 KB) - added by melchoyce 5 years ago.
no-image-set-after.png (471.6 KB) - added by melchoyce 5 years ago.
35826.patch (516 bytes) - added by Ankit K Gupta 5 years ago.
added patch
35826.1.patch (451 bytes) - added by Ankit K Gupta 5 years ago.
Updated patch file
35826.2.patch (642 bytes) - added by chris_dev 5 years ago.
"No image selected" is not vertically aligned because the border 2 pixels so I changed "top: 10px" to "8px"

Download all attachments as: .zip

Change History (11)

#1 @westonruter
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 4.5

@Ankit K Gupta
5 years ago

added patch

#2 @Ankit K Gupta
5 years ago

  • Keywords has-patch added; needs-patch removed

#3 follow-up: @westonruter
5 years ago

@ankit-k-gupta thank you for the patch. I think, however, that the CSS selector should be a bit more specific, scoped by the control's class name perhaps?

Last edited 5 years ago by westonruter (previous) (diff)

#4 in reply to: ↑ 3 @Ankit K Gupta
5 years ago

Replying to westonruter:

@ankit-k-gupta thank you for the patch. I think, however, that the CSS selector should be a bit more specific, scoped by the control's class name perhaps?

@westonruter Thanks for your feedback, I am not expert in CSS, hope this fulfill the requirement for this bug.
Added updated patch.
Thanks :)

@Ankit K Gupta
5 years ago

Updated patch file

@chris_dev
5 years ago

"No image selected" is not vertically aligned because the border 2 pixels so I changed "top: 10px" to "8px"

#5 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36639:

Customizer: Contain "No image set/selected" in dashed border.

Props Ankit K Gupta, chris_dev.
Fixes #35826.

#6 @johnbillion
5 years ago

  • Version changed from trunk to 3.4
Note: See TracTickets for help on using tickets.