#35826 closed enhancement (fixed)
Customizer: Contain "No Image Set" in dashed border
Reported by: | melchoyce | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Customize | Keywords: | good-first-bug has-patch |
Focuses: | ui | Cc: |
Description
In the Customizer, in panels like Site Identity, Header Image, and Background Image, the "no image set" label seems to just float there. We should add a dashed border to that container div so it looks grounded.
See attached images for before/after.
Attachments (5)
Change History (11)
#1
@
9 years ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 4.5
#3
follow-up:
↓ 4
@
9 years ago
@ankit-k-gupta thank you for the patch. I think, however, that the CSS selector should be a bit more specific, scoped by the control's class name perhaps?
#4
in reply to:
↑ 3
@
9 years ago
Replying to westonruter:
@ankit-k-gupta thank you for the patch. I think, however, that the CSS selector should be a bit more specific, scoped by the control's class name perhaps?
@westonruter Thanks for your feedback, I am not expert in CSS, hope this fulfill the requirement for this bug.
Added updated patch.
Thanks :)
@
9 years ago
"No image selected" is not vertically aligned because the border 2 pixels so I changed "top: 10px" to "8px"
added patch