Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#35845 closed defect (bug) (wontfix)

Duplicate semicolons in a lot of files

Reported by: renehermi's profile ReneHermi Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.4.2
Component: General Keywords:
Focuses: Cc:

Description

Search the entire WP 4.4.2 rep for ;; and you will get several js, css and php files which contains duplicate semicolons.

  • wp-admin\custom-header.php
  • wp-content\themes\twentysixteen\rtl.css
  • wp-includes\ID3\module.tag.id3v2.php
  • wp-includes\js\admin-bar.min.js

and a few more

Note: Netbeans is one of the IDE's that is not recognizing this code issues. So this coding issues are easily overlooked.

Change History (1)

#1 @swissspidy
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hey there, thanks for creating this ticket!

First, ID3 is an external library and admin-bar.min.js is an automatically generated file. Second, we usually don't do code refactoring just for the sake of it. See https://make.wordpress.org/core/handbook/contribute/code-refactoring/.

Hence we don't accept changes for removing unneeded whitespace etc. The reason being that when using SVN/Git blame we'd rather see the code change history than whitespace changes which makes debugging much easier.

Note: See TracTickets for help on using tickets.