WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#35853 closed defect (bug) (fixed)

Media Library Add new button doesn't show the inline uploader anymore

Reported by: imath's profile imath Owned by: adamsilverstein's profile adamsilverstein
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: Media Keywords: has-patch needs-testing
Focuses: javascript Cc:

Description

Since r36546, when you click on the add new button, nothing happens, before the inline uploader was shown and it was possible to upload.

https://cldup.com/-JRJTMntgm.png

Attachments (1)

35853.diff​ (1.2 KB) - added by adamsilverstein 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @ocean90
7 years ago

  • Component changed from External Libraries to Media
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.5
  • Owner set to adamsilverstein
  • Status changed from new to reviewing

@adamsilverstein
7 years ago

#2 @adamsilverstein
7 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

@imath Thanks for the bug report. Can you test the attached patch to confirm that it resolves the issue for you?

In 35853.diff​:

  • Rework our handling of the 'toggle:upload:attachment' event using .on vs .listenTo for better compatibility with the current version of Backbone.

Fixes an issue where the upload area wouldn't open when clicking the 'Add New' button on the media grid screen (and possibly other places) since r36546.

#3 @imath
7 years ago

Hi @adamsilverstein yw, i've tested the patch and i confirm it solves the issue. Thanks a lot for the fix :)

#4 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 36575:

Media Library: After [36546] restore the "Add new" functionality.

Rework handling of the 'toggle:upload:attachment' event using .on vs .listenTo for better compatibility with the current version of Backbone.

Props adamsilverstein.
See #34350.
Fixes #35853.

Note: See TracTickets for help on using tickets.