WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#35893 closed defect (bug) (fixed)

number_format_i18n() inline documentation wrongly identifies first param as int

Reported by: salcode's profile salcode Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.0
Component: Formatting Keywords: has-patch commit
Focuses: docs Cc:

Description

The first parameter of function number_format_i18n() is erroneously identified as an int in the inline documentation.

Inside number_format_i18n() the value is passed to the PHP native function number_format() which takes a float as the first parameter (see ​http://php.net/manual/en/function.number-format.php).

Attachments (1)

35893.diff​ (845 bytes) - added by salcode 9 years ago.

Download all attachments as: .zip

Change History (6)

@salcode
9 years ago

#1 @swissspidy
9 years ago

  • Keywords has-patch added

#2 @DrewAPicture
9 years ago

  • Milestone changed from Awaiting Review to 4.5

#3 @swissspidy
9 years ago

  • Keywords commit added

#4 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36644:

Docs: Correct $number type in number_format_i18n().

Props salcode.
Fixes #35893.

#5 @johnbillion
9 years ago

  • Version changed from trunk to 4.0
Note: See TracTickets for help on using tickets.