Permit sticky posts to affect the query in REST_REQUEST

[danielbachhuber]

Needed for ​https://github.com/WP-API/WP-API/issues/2210

[jorbin]

In 36696:

Permit sticky posts to affect the query in REST_REQUEST

Needed for ​https://github.com/WP-API/WP-API/issues/2210

Props danielbachhuber.
Fixes #35907.

[jorbin]

In 36699:

Revert r36696

This broke embeds. Needs a better solution to also make sure all queries from the REST API aren't broken.

see #35907.

[johnbillion]

In 40545:

REST API: Remove a useless unit test.

See #35907, #38373

[Mamaduka]

I think this was fixed by #50213.

The fix should be applied to this condition in WP_REST_Posts_Controller for it to work. The isset( $query_args['ignore_sticky_posts'] ) is always false unless the value is filtered.

​https://github.com/WordPress/wordpress-develop/blob/21be4bc5f1e5af7c96c25d13315a9bf578b4aea7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L1197-L1199

Fixing this will make Query block results consistent between the editor and front-end. See:

• ​https://github.com/WordPress/gutenberg/issues/68570
• ​https://github.com/WordPress/gutenberg/issues/44471

@joemcgill, @desrosj, can we move this to WP 6.8 milestone?

[audrasjb]

Moving to milestone 6.8 with high priority as asked by @Mamaduka as it is a blocker for some bugfixes on the Editor side.

Gutenberg ticket: ​https://github.com/WordPress/gutenberg/pull/68970
Trac ticket: https://core.trac.wordpress.org/ticket/35907

Let's put it in with true for ignoring the stickies.

My one last naming things question is whether it should be plural ignore_stickies

Let's put it in with true for ignoring the stickies.

So, merge as it is. Send ' true ' if the user doesn't want sticky posts to stick.

My one last naming things question is whether it should be plural ignore_stickies

Don't have a strong opinion here, but there's not much difference between ignore_stickies and ignore_sticky. The latter is closer to the WP_Query argument, so it is probably easier to remember.

My one last naming things question is whether it should be plural ignore_stickies

Don't have a strong opinion here, but there's not much difference between ignore_stickies and ignore_sticky. The latter is closer to the WP_Query argument, so it is probably easier to remember.

My thought (bike shedding??) is that the current name is singular whereas the WP_Query is plural with the _posts. The reason for my suggestion is that multiple posts made be ignored.

But the rest api has stickymaybe the opportunity has been missed and I should stop over thinking it :)

But the rest api has sticky maybe the opportunity has been missed

Considering the existing argument, I'm leaning towards ignore_sticky.

Dancer, works for me!

[peterwilsoncc]

In 59801:

REST API: Add support for the ignore_sticky_posts argument.

Introduce ignore_sticky as a boolean argument for the posts endpoint for requests without the sticky posts being stuck. The new argument defaults to false with the value of the argument passed to WP_Query's ignore_sticky_posts parameter.

Props audrasjb, danielbachhuber, joemcgill, johnbillion, jorbin, mamaduka, rmccue.
Fixes #35907.

Thanks, @peterwilsoncc!

[wildworks]

It seems that this [59081] caused a problem. See #63339.

[SirLouen]

More affected #63307

[jorbin]

In 60197:

REST API: Change posts endpoint to ignore_sticky=true by default

This restores the 6.7 and below behavior for the posts endpoint which did not include sticky posts by default.

Follow-up to [59801].

Props nikunj8866, SirLouen, ankitmaru, wildworks, karthikeya01, Mamaduka, spacedmonkey, jorbin.
Fixes #63307. See #35907.

[jorbin]

In 60200:

REST API: Change posts endpoint to ignore_sticky=true by default

This restores the 6.7 and below behavior for the posts endpoint which did not include sticky posts by default.

Follow-up to [59801].

Reviewed by desrosj.
Merges [60197] to the 6.8 branch.

Props nikunj8866, SirLouen, ankitmaru, wildworks, karthikeya01, Mamaduka, spacedmonkey, jorbin.
Fixes #63307. See #35907.