get_edit_term_link should not require $taxonomy

[nicdford]

Both get_term() and get_term_link() no longer require $taxonomy to work anymore and get_edit_term_link() should follow suit. It would be best to utilize the $term->taxonomy if one isn’t set.

Special thanks to @sc0ttkclark for helping me with my first ticket! :)

[welcher]

Welcome and thanks for the patch!

[sc0ttkclark]

Patch incoming :)

[boonebgorges]

Thanks! Let's sneak this in.

Side note: when generating your patches, please set your editor config to use tabs rather than spaces :)

[nicdford]

Will do! Thanks @boonebgorges

[boonebgorges]

In 36646:

Make $taxonomy parameter optional in get_edit_term_link().

Props nicdford, sc0ttkclark.
Fixes #35922.

[swissspidy]

@boonebgorges While working on #36224 I noticed that test_cap_check_should_use_correct_taxonomy_when_taxonomy_is_not_specified is not 100% correct / incomplete.

First, manage_terms is not a direct taxonomy property, but can only be passed as part of the capabilities array.
Second, get_edit_term_link() checks against edit_terms capability, not manage_terms.
Third, the wptests_tax_subscriber taxonomy isn't even used in the test.

I'd add a new test to check that the custom capabilities get respected when using get_edit_term_link().

[boonebgorges]

Yikes, you are right. Not sure what I was thinking.

[boonebgorges]

In 36986:

Fix test related to cap check in get_edit_term_link().

The test was introduced in [36646] was intended to demonstrate that the cap
check in get_edit_term_link() uses the custom capability from the correct
taxonomy when $taxonomy is not specified but must be inferred from the
provided term. However, the test was wrongly written in pretty much every way.
Antiprops boonebgorges.

Props swissspidy.
See #35922.

[flixos90]

In 58807:

Taxonomy: Ensure get_edit_term_link() produces the correct result when called without taxonomy.

This fixes an oversight missed in [36646].

Props debarghyabanerjee.
Fixes #61726.
See #35922.