WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#35952 closed enhancement (fixed)

Unit test: Tests covering is_serialized_string method

Reported by: borgesbruno Owned by: boonebgorges
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-unit-tests has-patch
Focuses: Cc:
PR Number:

Description

I've created tests for the method is_serialized_string on /wp-includes/functions.php file, to improve de code coverage.

Attachments (2)

functions.diff (869 bytes) - added by borgesbruno 4 years ago.
35952.patch
functions.2.diff (928 bytes) - added by borgesbruno 4 years ago.

Download all attachments as: .zip

Change History (11)

@borgesbruno
4 years ago

35952.patch

#1 @ericlewis
4 years ago

Thanks for the patch and welcome to WordPress' bug tracker @borgesbruno!

If you could, please submit the patch against the root of the WordPress directory instead of in a subdirectory. Here's some more tips for writing patches.

#2 @borgesbruno
4 years ago

Tks for the tip @ericlewis, I did that on the last file, sorry for the name of files, I was not able to remove or rename the attachments.
The functions2.diff is the right patch, the next patch I will do better, this is the first one.

Last edited 4 years ago by borgesbruno (previous) (diff)

#3 @borgesbruno
4 years ago

  • Component changed from General to Text Changes
  • Keywords has-unit-tests has-patch added

#4 @borgesbruno
4 years ago

  • Component changed from Text Changes to General

#5 @ericlewis
4 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @borgesbruno
4 years ago

  • Summary changed from Unit tests for is_serialized_string to Unit test: Tests covering is_serialized_string method

#7 @chriscct7
4 years ago

  • Version trunk deleted

#8 @boonebgorges
3 years ago

  • Milestone changed from Future Release to 4.6

#9 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 37357:

Add tests for is_serialized_string().

Props borgesbruno.
Fixes #35952.

Note: See TracTickets for help on using tickets.