Opened 9 years ago
Closed 9 years ago
#35954 closed task (blessed) (fixed)
Prevent test environment contamination when HTTPS related assertions fail
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
Several tests which are related to HTTPS alter the $_SERVER['HTTPS']
variable, but then perform assertions before this value is reset. When these assertions fail, it has a knock-on affect for other tests because the resets don't occur, and we get cascading failures as a result.
Ideally we should audit every one of our tests to ensure any environment changes (including things such as post type registration, messing with other superglobals, etc) only perform their assertions after the resets happen, but the HTTPS tests are what I'm focusing on for now.
Change History (6)
Note: See
TracTickets for help on using
tickets.
In 36711: