WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35956, comment 6


Ignore:
Timestamp:
03/05/2016 10:56:32 PM (6 years ago)
Author:
ocean90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35956, comment 6

    initial v1  
    44Ah yes, of course. So I think the issue really was with [36604].
    55
    6 Your sorting patch does appear to be work, but I think I've got to the root of the problem which addresses this and the issue reported in [#35873].
     6Your sorting patch does appear to be work, but I think I've got to the root of the problem which addresses this and the issue reported in #35873.
    77
    88When processing dependencies `$this->group` will be the minimum of the script's registered group and all preceding '''siblings'''. This is wrong because only a scripts 'ancestors' in the dependency chain should affect where it is loaded. Effectively `$this->group` introduced a form of global state which potentially corrupted the group of dependencies.  Sorting covers up this problem.
    99
    10 The real issue in [#35873] was that script were  not moving their dependencies to a lower group when necessary.  E.g. if you reversed patch [36604], I found the following failed to load the child script:
     10The real issue in #35873 was that script were  not moving their dependencies to a lower group when necessary.  E.g. if you reversed patch [36604], I found the following failed to load the child script:
    1111
    1212{{{