Make WordPress Core

Opened 9 years ago

Closed 8 years ago

#3596 closed defect (bug) (invalid)

Manage>Uploads Single Image View's wide image Input boxes are Too Small

Reported by: ryanfitzer Owned by: mdawaffe
Milestone: Priority: high
Severity: normal Version: 2.1
Component: Administration Keywords: invalid
Focuses: Cc:

Description (last modified by foolswisdom)

When managing an image via the Manage>Uploads single-image-view screen, if the image is too wide it squishes the URL, Title and Description input boxes to where they are unusable.

Attachments (3)

screengrab.jpg (237.9 KB) - added by ryanfitzer 9 years ago.
screenshot of problem
3596.diff (1.6 KB) - added by mdawaffe 9 years ago.
3596b.diff (1.6 KB) - added by mdawaffe 9 years ago.

Download all attachments as: .zip

Change History (23)

@ryanfitzer9 years ago

screenshot of problem

comment:1 @ryanfitzer9 years ago

  • Version set to 2.1

This is in 2.1 beta 4

comment:2 @foolswisdom9 years ago

  • Description modified (diff)
  • Owner changed from anonymous to mdawaffle
  • Summary changed from Manage>Uploads Single Image View's Input boxes are Too Small to Manage>Uploads Single Image View's wide image Input boxes are Too Small

comment:3 @mdawaffe9 years ago

  • Owner changed from mdawaffle to mdawaffe

waffe - no syrup needed.

comment:4 @mdawaffe9 years ago

I need more info about this bug.

For that file, was a thumbnail actually created? It would be in the same place on your server as the original but probably called whatever.thumbnail.jpg instead of whatever.jpg (the original).

I've attached a patch which may solve this problem.

@mdawaffe9 years ago

comment:5 @mdawaffe9 years ago

  • Keywords has-patch commit added
  • Status changed from new to assigned

comment:6 @ryanfitzer9 years ago

Yes, thumbnails were created for the images. The images were no larger than 780px wide (landscape format) when uploaded. I witnessed this in FF 2 on OSX 10.3.9 using a localhost environment via MAMP.

comment:7 @mdawaffe9 years ago

Do you have the ability to apply the patch above called 3596.diff? If so, does it help with this issue or the other issue you reported (#3597 - I think they are related)?

Can you also do the following debugging for me?

From your screengrab, it seems as though the image with ID = 9 is one for which this problem occurs. Do you have CocoaMySQL or PHPMyAdmin installed or some otherway to look at the raw database? If so, in your _postmeta table, find all the rows with post_id = 9 and paste each here.

We will figure this out :)

comment:8 @mdawaffe9 years ago

  • Priority changed from normal to high

comment:9 @ryanfitzer9 years ago

All this is doable. I won't be able to get at the computer (work computer) until tomorrow as I'm stuck at home sick. I'll get you everything The morning of the 19th.

@mdawaffe9 years ago

comment:10 @ryan9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4767]) Upload manager image viewer fixes from mdawaffe. fixes #3596

comment:11 @mdawaffe9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm not convinced this is fixed yet. Anyone seeing this problem please include the debugging info I mentioned above.

comment:12 @ryanfitzer9 years ago

Sorry, haven't had a chance to implement this. Still recovering. First chance I get I'll post back.

comment:13 @foolswisdom9 years ago

  • Milestone changed from 2.1 to 2.2
  • Owner changed from mdawaffe to ryanfitzer
  • Status changed from reopened to new

comment:14 @ryanfitzer9 years ago

  • Keywords patch tested-problem still exists added; manage image has-patch commit removed

I'm gettin' back to normal here. Sorry for the delay.
Plugged in 4767 to upload-functions.php. WP is finding the thumbs just fine on images uploaded after the upgrade from 2.0.x to 2.1. Images uploaded while using 2.0.x are still being shown using the full image, therefore, collapsing the input boxes according to the dimensions of the images.

Requested Database Lines:

INSERT INTO wp_postmeta VALUES (26, 9, '_wp_attached_file', '/homepages/30/d174426947/htdocs/wp-content/uploads/2007/01/primedwall.jpg');

INSERT INTO wp_postmeta VALUES (27, 9, '_wp_attachment_metadata', 'a:5:{s:5:"width";i:780;s:6:"height";i:585;s:14:"hwstring_small";s:23:"height=''96 width=128";s:4:"file";s:78:"/homepages/30/d174426947/htdocs/wp-content/uploads/2007/01/primedwall.jpg";s:5:"thumb";s:24:"primedwall.thumbnail.jpg";}');

comment:15 @foolswisdom9 years ago

  • Owner changed from ryanfitzer to mdawaffe

comment:16 @foolswisdom8 years ago

  • Keywords needs-patch added; patch tested-problem still exists removed
  • Milestone changed from 2.2 to 2.3

comment:17 @ryan8 years ago

  • Milestone changed from 2.3 to 2.4 (next)

comment:18 @westi8 years ago

  • Cc andy added

I assume this will be fixed in the new uploader.

This appears to be missing functionality at present though.

comment:19 @MtDewVirus8 years ago

  • Keywords invalid added; needs-patch removed

Using r7236, Manage Media doesn't provide a way to edit anything for the uploads. Basically all you can do is delete, view the posts associated with an upload, or view the uploaded file.

comment:20 @lloydbudd8 years ago

  • Milestone 2.5 deleted
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.