Unit tests for _n_noop & _nx_noop

[realloc]

I created the unit tests for _n_noop and _nx_noop. Additionally, I corrected a typo in the description of _n_noop.

[realloc]

Unit tests and correction of type in phpdoc of _n_noop

[swissspidy]

That's not a typo, just a third-person singular verb.

[realloc]

Replying to swissspidy:

That's not a typo, just a third-person singular verb.

I don't think so ... at least, it's inconsistent. Please have a look at the description of _nx_noop ;)

[swissspidy]

Yes, the docs are inconsistent. As ​per the handbook, third-person singular verbs should be used to describe what a function does. For example:

Registers plural strings in POT file, but doesn't translate them.

@realloc Would you mind creating a separate patch for the docs changes of these two functions?

[realloc]

Unit tests and correction of the description in the doc of the functions

[realloc]

Replying to swissspidy:

@realloc Would you mind creating a separate patch for the docs changes of these two functions?

Ok, thanks for pointing that out. This time, I asked also my English teacher - jut to be sure. :-D

[johnbillion]

Thanks again for writing tests, @realloc!

I think these tests are too tightly coupled to the internal implementation of _n_noop() and _nx_noop(). Testing that the function returns an array containing those elements is ok, but what really needs to be tested is whether their return values work when they're passed to translate_nooped_plural(). Testing the return value doesn't really prove anything with regard to these particular functions.

I think it would be better to combine the tests with some for translate_nooped_plural(), that way we ensure that the *_noop() functions correctly interact with translate_nooped_plural().

[realloc]

Interaction with translate_nooped_plural() added

[realloc]

Replying to johnbillion:

I think it would be better to combine the tests with some for translate_nooped_plural(), that way we ensure that the *_noop() functions correctly interact with translate_nooped_plural().

Thank you very much for helping here, John. I changed the tests so that these functions interact with translate_nooped_plural() now.

[SergeyBiryukov]

In 36765:

Docs: Correct _n_noop() and _nx_noop() descriptions to use third-person singular verbs.

Props realloc.
See #35961.

[SergeyBiryukov]

In 36766:

L10n: Add unit tests for _n_noop() and _nx_noop().

Props realloc.
Fixes #35961.