WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#35980 closed defect (bug) (fixed)

Media attachments show urlencoded permalinks on attachment editing screen

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

Publish a regular post with a title of صورة and the permalink on the post editing screen will be displayed as:

Permalink: https://example.com/2016/02/صورة/

However if you upload an image named صورة.jpg then the permalink on its attachment editing screen will be shown urlencoded:

Permalink: https://example.com/%d8%b5%d9%88%d8%b1%d8%a9/

Attachments (1)

35980.diff​ (5.1 KB) - added by johnbillion 7 years ago.

Download all attachments as: .zip

Change History (4)

#1 @johnbillion
7 years ago

  • Owner set to johnbillion
  • Status changed from new to accepted

@johnbillion
7 years ago

#2 @johnbillion
7 years ago

  • Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed
  • Milestone changed from Awaiting Review to 4.5

35980.diff​ fixes the issue, adjusts existing tests for get_sample_permalink_html() so they also consider urlencoding of the permalink, and adds a new test for get_sample_permalink_html() for attachments.

#3 @johnbillion
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 36853:

Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.

Fixes #35980

Note: See TracTickets for help on using tickets.