Add .current-ancestor class to any relative menu item ancestor

[vovkasolovev]

Right now there is .current-page-ancestor and .current-post-ancestor for pages and posts and no any class for archives, category, taxonomy or custom post types ancestors added to items in nav-menu.

I think it will be usefull, for indication navigation depth purposes, to add .current-ancestor class to ANY menu item if "current page" is child/successor to anything in menu (parents, archive, category, taxonomy etc. menu items).

[vovkasolovev]

Replying to JeffPaul:

A ​decision was made to reopen tickets that were closed in the bulk edit that this ticket was affected by. This ticket is being placed back into the Awaiting Review milestone so it can be individually evaluated and verified to determine if it is still relevant/valid or reproducible.

Patiently waiting for the .current-ancestor tag to indicate selected item in menu for archives, category, taxonomy and custom post types pages.

[Mista-Flo]

Add classes for all custom post types and custom taxonomies - current ancestors

[Mista-Flo]

The patch is really simple, instead of just adding this class for page, it add it for all custom post types and taxonomies.

Is unit tests really needed ?

[vovkasolovev]

Replying to Mista-Flo:

The patch is really simple, instead of just adding this class for page, it add it for all custom post types and taxonomies.

Sorry, If you decide to add specific type, maybe we can add both:
.current-ancestor and .current_%s_ancestor

Similar how we have with item classes:
.menu-item and .menu-item-type-taxonomy.

Reason to have short .current-ancestor (without %argument) for all the parents is to be able to select and to stylize menu items in bread crumbs way, without specifying their type, level or something else.

[Mista-Flo]

Yeah sure it makes sense but you already have the general class "current-menu-ancestor", so I guess it's what you want.

By the way, I have added a new patch just for refactoring purpose, tried to merge some if state to avoid extra code lines.

[Mista-Flo]

Refactoring

[Mista-Flo]

Fix class name and avoid using sprintf

[vovkasolovev]

Replying to Mista-Flo:

Yeah sure it makes sense but you already have the general class "current-menu-ancestor", so I guess it's what you want.

Sorry, that is what I asked for. Right now there is no "current-menu-ancestor" (or "current-ancestor" as I named it) for CPT and archives. They have only type-related classes like "current-post-ancestor".

[joedolson]

Looking at this issue and past discussions of it in the accessibility channel, I don't think that this needs the accessibility focus.