Move the aria-label text into a separate translation string

[ramiy]

Old string:

• <a href="%1$s" aria-label="Logged in as %2$s. Edit your profile.">Logged in as %2$s</a>. <a href="%3$s">Log out?</a>

New string:

• <a href="%1$s" aria-label="%2$s">Logged in as %3$s</a>. <a href="%4$s">Log out?</a>

---

The text inside aria-label attribute was replaced with a %2$s placeholder.

This way the translation string is shorter and easier to translate.

BTW, in other string translations we do the same.

[ramiy]

The new code:

sprintf(
	__( '<a href="%1$s" aria-label="%2$s">Logged in as %3$s</a>. <a href="%4$s">Log out?</a>' ),
	get_edit_user_link(),
	sprintf( __( 'Logged in as %s. Edit your profile.' ), $user_identity ),
	$user_identity,
	wp_logout_url( apply_filters( 'the_permalink', get_permalink( $post_id ) ) )
)

[ramiy]

Related: #36013

[ramiy]

In the second patch I added esc_attr() to the aria-label text.

[ramiy]

The new code:

sprintf(
	__( '<a href="%1$s" aria-label="%2$s">Logged in as %3$s</a>. <a href="%4$s">Log out?</a>' ),
	get_edit_user_link(),
	esc_attr( sprintf( __( 'Logged in as %s. Edit your profile.' ), $user_identity ) ),
	$user_identity,
	wp_logout_url( apply_filters( 'the_permalink', get_permalink( $post_id ) ) )
)

[SergeyBiryukov]

In 36794:

I18N: Move the aria-label text in comment_form() to a separate string for easier translation.

Add translator comments.

Props ramiy.
Fixes #36014.

[ramiy]

Related: #36048