WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Last modified 3 months ago

#36030 new enhancement

Expose site icon on wp.getUsersBlogs

Reported by: daniloercoli Owned by:
Priority: normal Milestone: Future Release
Component: XML-RPC Version:
Severity: normal Keywords: has-patch 2nd-opinion has-unit-tests
Cc: Focuses:

Description

WordPress 4.3 has added the ability for site owners to manage their site’s favicon, but never exposed it over the XML-RPC protocol.

It's useful for XML-RPC clients to receive it back in the response of wp.getUsersBlogs, so they can show the proper icon beside the name of the site.

In the patch I've provided an empty value is returned if site_icon is not set on the blog. I've avoided returning a default value, since it's better to leave this responsibility to clients. If siteIcon is empty, the client should show their default icon, or nothing.

Attachments (1)

site-icon.diff​ (689 bytes ) - added by daniloercoli 11 years ago.

Download all attachments as: .zip

Change History (4)

@daniloercoli
11 years ago

#1 @daniloercoli
11 years ago

  • Keywords has-patch added

#2 @desrosj
7 years ago

  • Keywords needs-unit-tests 2nd-opinion added
  • Milestone → Future Release

Hi @daniloercoli,

Thanks for this! My apologies that it took so long to receive a response.

The patch still applies cleanly for me. XML-RPC has been in somewhat of a holding pattern not receiving much attention lately. I don't think it would hurt to add this, but I'd love to get more thoughts from other committers/contributors more familiar with the component.

It would also be great to add unit tests for these methods in the process.

This ticket was mentioned in ​PR #12278 on ​WordPress/wordpress-develop by ​@sainathpoojary.
3 months ago #3

  • Keywords has-unit-tests added; needs-unit-tests removed

Trac ticket: #36030

Note: See TracTickets for help on using tickets.