WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#36048 closed defect (bug) (fixed)

Move the aria-label text into a separate translation string in wp_plugin_update_row() and wp_theme_update_row()

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: accessibility, administration Cc:

Description

Related: #36014

The newly added aria-label="" in wp_plugin_update_row() and wp_theme_update_row() makes the translation string very hard to translate.

Replacing the text inside the aria-label attribute with a %3$s placeholder makes it shorter and translator-friendly.

See the attached patch.

Attachments (2)

36048.patch (7.6 KB) - added by ramiy 4 years ago.
36048-themes.patch (3.1 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-patch added

#2 @ramiy
4 years ago

Related: #35167 (The original ticket)

This ticket was mentioned in Slack in #accessibility by ramiy. View the logs.


4 years ago

#4 @ramiy
4 years ago

  • Focuses accessibility added

Same should be applied to themes get_theme_update_available() function.

See the second patch.

@ramiy
4 years ago

#5 @SergeyBiryukov
4 years ago

In 36844:

I18N: Move the aria-label text in wp_plugin_update_row() and wp_theme_update_row() to a separate string for easier translation.

Add translator comments.

Props ramiy.
See #36048.

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.5

#7 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36845:

I18N: Move the aria-label text in get_theme_update_available() to a separate string for easier translation.

Add translator comments.

Props ramiy.
Fixes #36048.

#8 @ocean90
4 years ago

In 36850:

I18N: Fix an invalid placeholder added in [36844].

See #36048.

#9 @SergeyBiryukov
4 years ago

In 38082:

I18N: Remove non-translatable link attributes from translatable strings in wp_plugin_update_row(), wp_theme_update_row(), and get_theme_update_available().

The resulting strings are much easier to translate.

See #36048.

Note: See TracTickets for help on using tickets.