#36086 closed task (blessed) (fixed)
Custom Logo: Add unit tests
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.5 | Priority: | normal |
| Severity: | normal | Version: | 4.6 |
| Component: | Customize | Keywords: | needs-patch |
| Focuses: | Cc: |
Attachments (2)
Change History (13)
This ticket was mentioned in Slack in #core by obenland. View the logs.
10 years ago
#4
@
10 years ago
test_the_custom_logo feels like it's just making sure that the_custom_logo is a wrapper to echo get_custom_logo. Would it make more sense to test expected HTML output?
Calling _remove_custom_logo() after an assertion means that it may not be run if the assertion fails. We should add that to the teardown.
Tests_WP_Custom_Logo doesn't use the wp_custom_logo property. Looks like it can be eliminated.
#7
@
10 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
The output in test_the_custom_logo is different when Twenty Sixteen is active, see https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/114894614#L1183.
Note: See
TracTickets for help on using
tickets.
@jorbin, would you mind reviewing these when you get a chance?