New strings for "media attachment detached" and "Media attachment reattached"

[bastho]

These sentences are redundant and not very friendly, but also hard to elegantly translate.
The term detached suggests that the media was an attachment before.

Here is the French example where the team is scratching its head:

​https://translate.wordpress.org/projects/wp/dev/admin/fr/default?filters[term]=media+attachment&filters[user_login]=&filters[status]=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort[by]=priority&sort[how]=desc

I suggest to to change the original strings into:

• The media ​file​ has been detached
• The media ​file​ has been reattached

[ocean90]

Introduced in [36328].

Old strings:

• Reattached %d attachment.
• Reattached %d attachments.
• Detached %d attachment.
• Detached %d attachments.

New strings:

• Media attachment reattached.
• %s media attachment reattached.
• %s media attachments reattached.
• Media attachment detached.
• %s media attachment detached.
• %s media attachments detached.

[netweb]

Following through the workflow of me adding an image that was already in the media library to a post:

1. In the list view of the image in the media library click "Attach"
2. Select the post/page to attach it to and click "Select"

Result: The notice is displayed at the top of the media library: Media attachment reattached.

Expected Result: A notice at the top of the media library: Media attachment added.

In the example above that image was not being "reattached" to anything, it had never been attached to anything, hence it was "added" to the post.

Reversing the above workflow to remove the media attachment by selecting "Detach" I see a notice Media attachment detached., and maybe this should be Media attachment removed. instead.

So even though the terms attach and detach are used on the action links, maybe the notices should use added and removed rather than attached and detached

[SergeyBiryukov]

Replying to netweb:

So even though the terms attach and detach are used on the action links, maybe the notices should use added and removed rather than attached and detached

I think "removed" implies removing from media library rather than from post.

[bastho]

Removing media attachments from media library is defined by delete.

But to be not confusing, we could use the terms linked and unlinked to a post.

[SergeyBiryukov]

36089.patch​ replaces "media attachment" in wp-admin/upload.php with "media file".

New strings:

• Media file updated.
• Media file reattached.
• %s media file reattached. / %s media files reattached.
• Media file detached.
• %s media file detached. / %s media files detached.
• Media file permanently deleted.
• %s media file permanently deleted. / %s media files permanently deleted.
• Media file moved to the trash.
• %s media file moved to the trash. / %s media files moved to the trash.
• Media file restored from the trash.
• %s media file restored from the trash. / %s media files restored from the trash.
• Error saving media file.

[ocean90]

Updates help text and a few more "media attachment"

[netweb]

The 36089.patch​ / 36089.2.patch​ patches make things a little clearer swapping out "attachment" for "file" :+1

Still, if I attach a media file to a post per my comment above it now states: Media file reattached., it should be Media file attached., the "Media file attached." string would cover both use cases if a media file is attached, or is reattached the string would accurately represent the action that occurred.

Should the help text mention page also?

If a media file has not been attached to a post or page, you will see that in the Uploaded To column, and can click on Attach to launch a small popup that will allow you to search for a post or page and attach the file.

[ocean90]

In 36887:

Media: Change wording for media files which aren't attached.

The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.

[SergeyBiryukov]

In 36987:

Media: Fix typo introduced in [36887].

Props claudiosanches.
Fixes #36230. See #36089.