WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36160 closed defect (bug) (fixed)

Comment content ul elements have no style in the Comment List Table or Moderate Comment screen

Reported by: rachelbaker Owned by: rachelbaker
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: administration Cc:
PR Number:

Description

In both the Moderate Comment and Comment List Table screens, moderators do not see any list-style formatting in comment content. The comment_content is displayed with the proper unordered list markup, but are displayed with a list-style: none CSS rule.


See screenshots*:
https://cldup.com/cFigYvYFE8.png
https://cldup.com/NFUVuJUlNl.png

  • in the above screenshots the following text is an unordered list:
<ul>
<li>As you wish.<li>
<li>Ye-ha!</li>
<li>Don't underestimate the Force.</li>
<li>Hokey religions and ancient weapons are no match for a good blaster at your side, kid.
I have traced the Rebel spies to her. Now she is my only link to finding their secret base.</li>
</ul>

Attachments (3)

36160.patch (166.4 KB) - added by juanfra 4 years ago.
36160-2.patch (380 bytes) - added by juanfra 4 years ago.
36160.3.patch (822 bytes) - added by rachelbaker 4 years ago.
Adds ul styles to the Moderate Comment Screen as well

Download all attachments as: .zip

Change History (11)

#1 @rachelbaker
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.6

#2 follow-up: @juanfra
4 years ago

This is because the default styles for ol is (wp-admin/css/common.css):

ol {
	list-style-type: decimal;
	margin-left: 2em;
}

While the default for ul is:

ul {
	list-style: none;
}

The following code makes the trick, but I'm not sure if we're missing some place as it is applied only on the comment table:

.widefat .column-comment ul {
	list-style: initial;
	margin-left: 2em;
}

If we are ok with this solution I'll happily send a patch with the rtl and minified versions.

P.S.: It seems that in Twenty Fifteen the lists within comments are not styled that well: https://cloudup.com/cIW-Bka8Lba (I'll open a new ticket for this one)

Last edited 4 years ago by juanfra (previous) (diff)

@juanfra
4 years ago

#3 in reply to: ↑ 2 @SergeyBiryukov
4 years ago

Replying to juanfra:

If we are ok with this solution I'll happily send a patch with the rtl and minified versions.

No need to patch minified or RTL files, a build task takes care of that.

#4 @juanfra
4 years ago

Hi @SergeyBiryukov, thanks for the heads up, didn't know that :)

@juanfra
4 years ago

#5 @juanfra
4 years ago

  • Keywords has-patch added; needs-patch removed

@rachelbaker
4 years ago

Adds ul styles to the Moderate Comment Screen as well

#6 @rachelbaker
4 years ago

In 36160.3.patch I applied the same ul style rules from 36160-2.patch to the Moderate Comment screen as well.

Screenshots:

Before: https://cldup.com/abfSUdWRj_-1200x1200.png

After: https://cldup.com/DmFWjfyi_U.png

#7 @juanfra
4 years ago

@rachelbaker Nice catch! I missed that one, sorry.

#8 @rachelbaker
4 years ago

  • Owner set to rachelbaker
  • Resolution set to fixed
  • Status changed from new to closed

In 37304:

Comments: Add unordered list styling to Comments List Table rows and Moderate Comment screen.

Fixes #36160

Props juanfra.

Note: See TracTickets for help on using tickets.