WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 16 months ago

#36183 reopened defect (bug)

Twenty Fourteen: Incompatibility with Right-To-Left (RTL) webpages AND the default video player

Reported by: samerafach Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.4.2
Component: Bundled Theme Keywords: needs-testing has-patch
Focuses: ui, rtl Cc:

Description (last modified by SergeyBiryukov)

First problem: There's a horrible bug in the Wordpress theme-foundation (Not only the Twenty-Fourteen theme that I currently use) that affects all objects that depend on the orientation, including drop-down menus. For example, in this page:

http://link.afach.de/rtlproblem

Apparently the menus are hidden to the fore-left, and then appear as drop-down when one hovers on them. Now the problem is that they really show up on the fore-left, creating an infinitely long horizontal scroll-bar. In the webpage, I fixed this problem using the CSS Tags:

    .primary-navigation ul ul, .primary-navigation ul ul ul {
        left:auto;
        right: -999em;
    }

    .primary-navigation ul li:hover > ul, .primary-navigation ul li.focus > ul {
        right: auto;
    }

which I got from an expert on Stackoverflow after this problem drove me really crazy because I, myself, am not a CSS expert. Anyway, please visit that page, and remove these tags, and see how the menus will appear, creating a very long horizontal scroll-bar that ruins the page.

Second problem: The same problem also exists with the default Wordpress video player. Without the following tag:

    .mejs-offscreen{
        right: -10000px;
        left: auto;
    }

the video-player will also create a very long horizontal scroll bar. Please try to remove it from the page and see for yourself.

Thank you for the great platform, Wordpress. I love it!

Attachments (1)

36183.patch (508 bytes) - added by parsmizban 16 months ago.
This patch will fix Video Player for RTL, Regards

Download all attachments as: .zip

Change History (12)

#1 follow-up: @SergeyBiryukov
2 years ago

  • Component changed from Formatting to Bundled Theme
  • Description modified (diff)
  • Focuses ui rtl added
  • Summary changed from Incompatibility of Twenty Fourteen with Right-To-Left (RTL) webpages AND the default video player to Twenty Fourteen: Incompatibility with Right-To-Left (RTL) webpages AND the default video player

#2 in reply to: ↑ 1 ; follow-up: @samerafach
2 years ago

Replying to SergeyBiryukov: It's not only about the theme. It's also about the Video player. I'm not sure whether I have to open another bug report for that.

#3 in reply to: ↑ 2 @SergeyBiryukov
2 years ago

Replying to samerafach:

It's not only about the theme. It's also about the Video player. I'm not sure whether I have to open another bug report for that.

Yes, please. Welcome to Trac and thank you for the reports :)

#4 follow-up: @karmatosed
2 years ago

  • Keywords needs-patch added

@samerafach, thanks for reporting this. Could you work on a patch for this? If not, we can absolutely work on one for you.

#5 @karmatosed
2 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 in reply to: ↑ 4 @samerafach
2 years ago

Replying to karmatosed:

@samerafach, thanks for reporting this. Could you work on a patch for this? If not, we can absolutely work on one for you.

I'm sorry, I would love to, but I'm not an expert to be able to write such a patch.

#7 @karmatosed
2 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

This really seems to be for the video player. Can you do a core patch for that please @samerafach?

#8 @samerafach
2 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@karmatosed This is not only for the video player. The video player is only half of the problem. Please read the report again and notice that there are two parts.

I'm sorry my skills are not good enough to fix this problem myself. I mentioned this before.

#9 @SergeyBiryukov
23 months ago

  • Milestone set to Awaiting Review

#10 @karmatosed
21 months ago

  • Keywords needs-testing added

@parsmizban
16 months ago

This patch will fix Video Player for RTL, Regards

#11 @parsmizban
16 months ago

  • Keywords has-patch added; needs-patch removed
Note: See TracTickets for help on using tickets.