WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36188, comment 16


Ignore:
Timestamp:
12/15/2016 06:58:39 PM (4 years ago)
Author:
seancjones
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36188, comment 16

    initial v1  
    1 @dlh I just tested this again on VVV. At first I thought you were right, because I was editing and local.wordpress-develop.dev was not updating the categories. Then, I realized I was in the wrong location. I ran again, under src.wordpress-develop.dev, and it uploaded fine. I also checked did_action('init') in upgrade.php prior to my patched line of "do_action( 'init' )" and it returned 0.
     1@dlh I just tested this again on VVV. At first I thought I was replicating, because I applied the patch and local.wordpress-develop.dev was not updating the categories. Then, I realized I was in the wrong location. I ran again, under src.wordpress-develop.dev, and it uploaded fine. I also checked did_action('init') in upgrade.php prior to my patched line of "do_action( 'init' )" and it returned 0.
    22
    33Can you tell me what OS you're using? What version of WordPress? I want to get to the point where I'm replicating what you're seeing (or vice versa :) ). That said, I definitely see your point in all this. It makes a lot of sense to do it manually. However, my concern is that a manual addition of those lines, while it would certainly work well, would violate DRY. Any time a new permastruct were added in the future, it would be highly likely to introduce the same bug without an additional few lines of code to cover it. If we went that route, it would probably make sense to build a function that goes through almost the same process as the extra_permastructs.