WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36202, comment 6


Ignore:
Timestamp:
10/14/2016 07:45:26 PM (5 years ago)
Author:
ryankienstra
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36202, comment 6

    initial v1  
    22
    33Hi @westonruter,
    4 You [https://core.trac.wordpress.org/ticket/36202#trac-change-4-1475464559859735 commented above] that on edit.php page, it's possible to refresh the page by clicking "Apply," before the ajax requests are sent. This [https://github.com/xwp/wordpress-develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889 commit] to this ticket's [https://github.com/xwp/wordpress-develop/pull/159/commits GitHub pull request] passes [https://github.com/xwp/wordpress-develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889#diff-731d55f699338973eaf2147ca0e0a61eR47 true] as the `immediate` argument to `_.debounce`. So this submits the first ajax request, without a `2000 ms` delay. So this fixes an issue where you click one "Columns" checkbox, like "Author," and quickly click "Apply."
     4You [https://core.trac.wordpress.org/ticket/36202#trac-change-4-1475464559859735 commented above] that on edit.php page, it's possible to refresh the page by clicking "Apply," before the ajax requests are sent. This [https://github.com/xwp/wordpress-develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889 commit] to this ticket's [https://github.com/xwp/wordpress-develop/pull/159/commits GitHub pull request] passes [https://github.com/xwp/wordpress-develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889#diff-731d55f699338973eaf2147ca0e0a61eR47 true] as the `immediate` argument to `_.debounce`. So this submits the first ajax request, without a `2000 ms` delay. This fixes an issue where you click one "Columns" checkbox, like "Author," and quickly click "Apply."
    55
    66But there's still an issue if you click on several screen options, and then click "Apply." This next [https://github.com/xwp/wordpress-develop/pull/159/commits/fc0aa235553e4c61b76aacf24f87b525c03da2cc commit] delays form submission until the current ajax request completes. But there could be 3 ajax requests queued with [https://github.com/xwp/wordpress-develop/pull/159/files#diff-731d55f699338973eaf2147ca0e0a61eR35 _.debounce]. This handler isn't very useful for clicking multiple screen options, and clicking "Apply."