Opened 9 years ago
Closed 7 years ago
#36206 closed enhancement (fixed)
Added the `$post` parameter in attachment_submitbox_misc_actions and post_submitbox_start action
Reported by: | sebastian.pisula | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch 2nd-opinion |
Focuses: | Cc: |
Description
Added the $post
parameter in attachment_submitbox_misc_actions and post_submitbox_start action
Attachments (2)
Change History (12)
#4
follow-up:
↓ 9
@
8 years ago
- Keywords 2nd-opinion added
- Milestone changed from Future Release to 4.8
36206.2.patch is a refresh that includes @tosho's patch from #40182 (with @since
entry).
It also passes $post
to media_submitbox_misc_sections
and audio_submitbox_misc_sections
actions for consistency.
Note that post_submitbox_start
is also used in link_submit_meta_box()
, which doesn't have a WP_Post
object, but has a link object instead. Should we pass the link object in that case or just null
? Current patch does the former.
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
#9
in reply to:
↑ 4
@
7 years ago
Replying to SergeyBiryukov:
Note that
post_submitbox_start
is also used inlink_submit_meta_box()
, which doesn't have aWP_Post
object, but has a link object instead. Should we pass the link object in that case or justnull
? Current patch does the former.
On second thought, the latter makes more sense.
$post
is passed throughpost_submitbox_misc_actions
action callbacks since r34895. Seems like these would be good for parity.