WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 20 months ago

#36207 closed defect (bug) (fixed)

Widget description in widgets is not using word-wrap: break-word

Reported by: Prelc Owned by: westonruter
Milestone: 4.9 Priority: low
Severity: trivial Version: 4.4.2
Component: Widgets Keywords: has-screenshots has-patch commit
Focuses: ui, administration Cc:

Description

Long word's without spaces goes out of the container.
I think that class .widget-description needs

overflow-wrap: break-word; 
word-wrap: break-word; 
-ms-word-break: break-all; 
word-break: break-word; 
-ms-hyphens: auto; 
-moz-hyphens: auto; 
-webkit-hyphens: auto; 
hyphens: auto; 

Attachments (5)

33c42d14-215b-4c26-6bff-fc2d0c0e3109.png (354.1 KB) - added by Prelc 3 years ago.
36207.diff (473 bytes) - added by metodiew 3 years ago.
36207-widgets-and-customizer-widgets.diff (982 bytes) - added by metodiew 3 years ago.
36207.2.diff (520 bytes) - added by metodiew 20 months ago.
use the proper path of the patch
36207.3.diff (497 bytes) - added by westonruter 20 months ago.
Remove -moz-hyphens and clean whitespace

Download all attachments as: .zip

Change History (14)

#1 @ramiy
3 years ago

  • Keywords has-screenshots added

#2 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Widgets
  • Focuses administration added

@metodiew
3 years ago

#4 @metodiew
3 years ago

I've submitted an updated version of the patch, because I've noticed we have the same issue in Customizer Widgets too, so 36207-widgets-and-customizer-widgets.diff should be a better fix. This might be not the best way to handle the issue, so I'm open for suggestions :)

@metodiew
20 months ago

use the proper path of the patch

#5 @metodiew
20 months ago

I'm at WordCamp Varna Contributor Day and I've decided to go and check my old patches. It seems like I didn't do the svn diff properly. Now the attached file has a fix of this.

#6 @melchoyce
20 months ago

  • Milestone changed from Awaiting Review to 4.9
  • Priority changed from normal to low
  • Severity changed from normal to trivial

Seems like a nice little update to make in 4.9. @westonruter correct me if I'm wrong but I don't think we need to worry about prefixes because that stuff's added automatically in pre-commit, right?

#7 @westonruter
20 months ago

Prefixes do need to be included in the patch. They are added via grunt precommit:css. It keeps all of the prefixed properties other than -moz-hyphens, so that one be removed.

@westonruter
20 months ago

Remove -moz-hyphens and clean whitespace

#8 @melchoyce
20 months ago

  • Keywords has-patch commit added

Looks good, let's get this in.

#9 @westonruter
20 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 41339:

Widgets: Use word-wrap: break-word for available widget descriptions.

Props metodiew.
Fixes #36207.

Note: See TracTickets for help on using tickets.