WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#36222 closed defect (bug) (fixed)

Can't exit DFW mode with keyboard shortcut

Reported by: ericlewis's profile ericlewis Owned by: azaozz's profile azaozz
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: Editor Keywords: needs-patch
Focuses: Cc:

Description

Pressing the TinyMCE access modifier + w enables DFW mode. Should this disable DFW mode as well? It does not.

Change History (5)

#1 @ericlewis
9 years ago

Seems to be that ​fadeOut hits on any keypress.

Perhaps ​this conditional check should check if the shortcut is being pressed on the Mac?

#2 @azaozz
9 years ago

  • Milestone changed from Awaiting Review to 4.5
  • Version set to trunk

Perhaps this conditional check should check if the shortcut is being pressed on the Mac?

Yep, looks that way. The Mac shortcut was just fixed, need to exclude it from fadeOut too.

#3 @kirasong
9 years ago

  • Keywords needs-patch added

This ticket was mentioned in ​Slack in #core by chriscct7. ​View the logs.
9 years ago

#5 @azaozz
9 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 37003:

Editor: fix exiting DFW with the keyboard shortcut on Mac (Opt+Ctrl+W).

Fixes #36222.

Note: See TracTickets for help on using tickets.