WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#36222 closed defect (bug) (fixed)

Can't exit DFW mode with keyboard shortcut

Reported by: ericlewis Owned by: azaozz
Priority: normal Milestone: 4.5
Component: Editor Version: 4.6
Severity: normal Keywords: needs-patch
Cc: Focuses:

Description

Pressing the TinyMCE access modifier + w enables DFW mode. Should this disable DFW mode as well? It does not.

Change History (5)

#1 @ericlewis
11 years ago

Seems to be that ​fadeOut hits on any keypress.

Perhaps ​this conditional check should check if the shortcut is being pressed on the Mac?

#2 @azaozz
11 years ago

  • Milestone Awaiting Review → 4.5
  • Version → trunk

Perhaps this conditional check should check if the shortcut is being pressed on the Mac?

Yep, looks that way. The Mac shortcut was just fixed, need to exclude it from fadeOut too.

#3 @kirasong
11 years ago

  • Keywords needs-patch added

This ticket was mentioned in ​Slack in #core by chriscct7. ​View the logs.
11 years ago

#5 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In 37003:

Editor: fix exiting DFW with the keyboard shortcut on Mac (Opt+Ctrl+W).

Fixes #36222.

Note: See TracTickets for help on using tickets.