Host header should not include port in WP_Http_Streams

[bangelov]

If you set Host header that includes port in wp_remote_* methods and you are using WP_Http_Streams, port will be doubly added into the Host header which breaks the HTTP request

Example request:

<?php
wp_remote_post( 'http://example.org', array( 'headers' => array( 'Host' => 'localhost:8080' ) );

will become localhost:8080:8080 because the following code doesn't strip the port from the Host header

<?php
if ( isset( $r['headers']['Host'] ) || isset( $r['headers']['host'] ) ) {
        if ( isset( $r['headers']['Host'] ) )
                $arrURL['host'] = $r['headers']['Host'];
        else
                $arrURL['host'] = $r['headers']['host'];
        unset( $r['headers']['Host'], $r['headers']['host'] );
}

Solution:

<?php
if ( isset( $r['headers']['Host'] ) || isset( $r['headers']['host'] ) ) {
        if ( isset( $r['headers']['Host'] ) )
                $arrURL['host'] = array_shift( explode( ':', $r['headers']['Host'] ) );
        else
                $arrURL['host'] = array_shift( explode( ':', $r['headers']['host'] ) );
                unset( $r['headers']['Host'], $r['headers']['host'] );
        }

[bangelov]

I am adding new and better solution on the problem because if Host header contain IPv6 the above logic will fail

<?php
if ( isset( $r['headers']['Host'] ) || isset( $r['headers']['host'] ) ) {
        if ( isset( $r['headers']['Host'] ) )
                $arrURL['host'] = preg_replace( '/:\d+$/', '', $r['headers']['Host'] );
        else
                $arrURL['host'] = preg_replace( '/:\d+$/', '', $r['headers']['host'] );
        unset( $r['headers']['Host'], $r['headers']['host'] );
}

[bangelov]

new fix

[dd32]

This was fixed by switching to Requests / fixed in #37991