Opened 9 years ago
Closed 8 years ago
#36264 closed enhancement (fixed)
Make wpList easier to contribute to
Reported by: | obenland | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch |
Focuses: | javascript, docs | Cc: |
Description
I wanted to use wpList
for the plugin directory rewrite to take advantage of the built-in data and DOM manipulation but was confronted with a very hard to understand code base with little to no documentation.
I took the time to expand variable names and add some documentation as I waded through the file, learning and understanding what it does. Please find attached patch with the (preliminary) results.
This might muddy some of the file's blame history, but I think it's a decent price to pay for some documentation there, leading to more than a handful of people understanding what it even does in the first place.
Attachments (2)
Change History (16)
This ticket was mentioned in Slack in #core by chriscct7. View the logs.
9 years ago
This ticket was mentioned in Slack in #core by obenland. View the logs.
8 years ago
#7
@
8 years ago
- Keywords 4.7-early added
@obenland this is amazingly helpful. Thank you for doing this. Any reason this ticket (other than time) didn't make 4.6?
#9
@
8 years ago
I do not have any problems with docs/cleanup, just want a second eye on the docs (formatting and content) for peace of mind.
#10
@
8 years ago
- Keywords 4.7-early removed
- Milestone changed from Future Release to 4.7
- Owner set to obenland
- Status changed from new to accepted
Updated patch to reflect changes in 4.6.
@DrewAPicture, would you mind giving it a final look-over?
#12
@
8 years ago
Whenever this gets committed, please give @rommelxcastro props for the parallel work he put into #34917.
@helen I'd like to proceed with this to make
wp-lists
easier to work with and contribute to in the future. You mentioned that we should try to avoid a total refactor in a couple of places and while this is not a refactor but just a prettification, I still wanted to give you an opportunity to veto if you see issues with it.