WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36266 closed defect (bug) (fixed)

Emoji Diversity support test fails in Safari

Reported by: pento Owned by: pento
Milestone: 4.4.3 Priority: normal
Severity: normal Version: 4.4.1
Component: Emoji Keywords: fixed-major
Focuses: javascript Cc:

Description

Safari supports the entire Unicode 8.0 set, but it's failing our test for emoji diversity support, which suggests our test is wrong.

Change History (5)

#1 @mikeschroder
4 years ago

  • Owner set to pento
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by mike. View the logs.


4 years ago

#3 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37028:

Emoji: Fix the diversity emoji check in Safari.

When the browser test for diversity emoji was added in [36160], it included a workaround for Chrome not being able to compare Uint8ClampedArray objects directly, by converting them to a string. Unfortunately, Safari doesn't support the Uint8ClampedArray.toString() method correctly, so the test was incorrectly failing in Safari.

Fixes #36266 for trunk.

#4 @pento
4 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37090:

Emoji: Fix the diversity emoji check in Safari.

When the browser test for diversity emoji was added in [36160], it included a workaround for Chrome not being able to compare Uint8ClampedArray objects directly, by converting them to a string. Unfortunately, Safari doesn't support the Uint8ClampedArray.toString() method correctly, so the test was incorrectly failing in Safari.

Merge of [37028] to the 4.4 branch.

Fixes #36266.

Note: See TracTickets for help on using tickets.