WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36292, comment 3


Ignore:
Timestamp:
03/22/2016 08:11:48 AM (6 years ago)
Author:
rmccue
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36292, comment 3

    initial v1  
    22> this is due to the current implementation, which converts string-based rules to objects for ease of internal handling. We can instead use just-in-time conversion after the pattern matching, which reduces this significantly; updated patch coming soon.
    33
    4 I profiled this, and it comes out to a negligible difference over the non-object implementation (as is expected). However, this is potentially a temporary gain, as one would expect over time that code would generally switch to object-based.
     4I profiled this ([https://github.com/rmccue/rewrite-ng-profiling tool source]), and it comes out to a negligible difference over the non-object implementation (as is expected). However, this is potentially a temporary gain, as one would expect over time that code would generally switch to object-based.