WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36296 closed defect (bug) (fixed)

Docs: add missing docs to WP_oEmbed class

Reported by: ramiy Owned by: DrewAPicture
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

Add missing docs to class properties.

Add missing @since and @access to methods.

See also: ticket #32246 (comment 325)

Attachments (1)

class-oembed.php.patch (3.2 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (8)

#1 @ramiy
4 years ago

  • Keywords has-patch added

#2 @DrewAPicture
4 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to DrewAPicture
  • Status changed from new to reviewing

#3 @DrewAPicture
4 years ago

In 37067:

Docs: Improve and add missing DocBlocks for methods and properties in WP_oEmbed.

Props ramiy.
See #36296.

#4 @DrewAPicture
4 years ago

In 37068:

Docs: Use third-person singular verbs for summary DocBlocks in WP_oEmbed.

Also fixes inline @see formatting in appropriate places (summaries should not contain tags or markdown).

Props ramiy.
See #36296.

#5 @DrewAPicture
4 years ago

In 37069:

Docs: Properly mark $args parameters in two WP_oEmbed methods as optional.

Also clarify that the $args parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.

#6 @swissspidy
4 years ago

@DrewAPicture Anything else here that needs to be covered?

#7 @DrewAPicture
4 years ago

  • Milestone changed from Future Release to 4.5
  • Resolution set to fixed
  • Status changed from reviewing to closed

@swissspidy Yeah, I think this was probably meant to be closed on 4.5. Closing now. New tickets for any other issues.

Note: See TracTickets for help on using tickets.