WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36304 closed enhancement (fixed)

Remove automatic embed support for Google Video, it's dead

Reported by: Viper007Bond Owned by: swissspidy
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

While Google Video has been retired for years, embeds continued to work. However it looks like it's now officially 110% dead. The Flash file used to embed the videos is 404: http://video.google.com/googleplayer.swf

We should remove the custom embed functionality from WordPress core.

Attachments (3)

36304.patch (2.6 KB) - added by Viper007Bond 3 years ago.
36304.2.patch (2.6 KB) - added by Viper007Bond 3 years ago.
Deprecate the function instead of removing it
36304.diff (3.1 KB) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (15)

@Viper007Bond
3 years ago

#1 @DrewAPicture
3 years ago

  • Summary changed from Remove support for Google Video, it's dead to Remove oEmbed support for Google Video, it's dead

#2 @Viper007Bond
3 years ago

  • Summary changed from Remove oEmbed support for Google Video, it's dead to Remove automatic embed support for Google Video, it's dead

Oops, good call. My original title wasn't as clear as it could have been.

Although if we're nitpicking, it isn't oEmbed functionality but rather provided by a custom handler within WordPress itself. :)

#3 follow-up: @johnbillion
3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version 4.4.2 deleted

wp_embed_handler_googlevideo() should be deprecated (and altered to return an empty string) to avoid fatals in case a theme or plugin calls it.

#4 in reply to: ↑ 3 @Viper007Bond
3 years ago

Replying to johnbillion:

wp_embed_handler_googlevideo() should be deprecated (and altered to return an empty string) to avoid fatals in case a theme or plugin calls it.

While that'd be unusual, I can understand that concern especially since it wasn't marked as internal. Fresh patch incoming.

@Viper007Bond
3 years ago

Deprecate the function instead of removing it

#5 @swissspidy
3 years ago

  • Milestone changed from Future Release to 4.6

#6 @swissspidy
3 years ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by ocean90. View the logs.


3 years ago

@swissspidy
3 years ago

#8 @swissspidy
3 years ago

  • Keywords commit added

#9 @swissspidy
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37744:

Embeds: Remove support for Google Video.

While the service has been retired for years, it now has completely stopped working. Thus there is no reason to keep it.

Props Viper007Bond.
Fixes #36304.

#10 @DrewAPicture
3 years ago

  • Keywords needs-docs added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

@swissspidy We also need to update the provider table in the hook doc for oembed_providers.

Looks like it was never actually added to the active providers table (whoops), but we should add it to the table for providers no longer supported. Appears to have been originally added in 2.9.0.

#11 follow-up: @swissspidy
3 years ago

It's not an oEmbed provider though, but was added as a custom embed provider instead. That means the oembed_providers filter isn't really relevant. How much sense does it make to add it to the oEmbed providers table?

#12 in reply to: ↑ 11 @DrewAPicture
3 years ago

  • Keywords needs-docs removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to swissspidy:

It's not an oEmbed provider though, but was added as a custom embed provider instead. That means the oembed_providers filter isn't really relevant. How much sense does it make to add it to the oEmbed providers table?

That's fair. We should find somewhere central to document the default embed handlers, but that's another ticket. Re-closing.

Note: See TracTickets for help on using tickets.