WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 16 months ago

#36310 new defect (bug)

a small fix for endless update nagging in latest hhvm

Reported by: natostanco Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords: reporter-feedback
Focuses: Cc:

Description

On [php] => 7.0.99-hhvm
on this line the null parameter makes the http_build_query return null, causing the "please update!" message of doom, changing it to false solves it.

Change History (4)

#1 @netweb
19 months ago

  • Keywords reporter-feedback added
  • Version changed from 4.4.2 to 3.7

@natostanco Welcome to Trac and thanks for the creating the ticket :)

What version of HHVM are you using?

The latest version is 3.13.1 so I am trying to work out where 7.0.99-hhvm comes from

#2 @natostanco
19 months ago

I believe it was the php version reported by wp, maybe from phpinfo? when I tested this I was on hhvm 3.12 iirc

#3 @ocean90
16 months ago

@natostanco Are you using PHP7 in strict mode? Found this issue for Guzzle: https://github.com/guzzle/guzzle/issues/1366

<?php
declare(strict_types=1);
http_build_query( [], null, '&' );

produces a fatal error: Uncaught TypeError: http_build_query() expects parameter 2 to be string, null given

#4 @natostanco
16 months ago

hhvm.php7.all = 1

enforces this typecheck

Note: See TracTickets for help on using tickets.