Make WordPress Core

Opened 8 years ago

Closed 5 years ago

#36310 closed defect (bug) (wontfix)

a small fix for endless update nagging in latest hhvm

Reported by: natostanco's profile natostanco Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords:
Focuses: Cc:


On [php] => 7.0.99-hhvm
on this line the null parameter makes the http_build_query return null, causing the "please update!" message of doom, changing it to false solves it.

Change History (5)

#1 @netweb
8 years ago

  • Keywords reporter-feedback added
  • Version changed from 4.4.2 to 3.7

@natostanco Welcome to Trac and thanks for the creating the ticket :)

What version of HHVM are you using?

The latest version is 3.13.1 so I am trying to work out where 7.0.99-hhvm comes from

#2 @natostanco
8 years ago

I believe it was the php version reported by wp, maybe from phpinfo? when I tested this I was on hhvm 3.12 iirc

#3 @ocean90
8 years ago

@natostanco Are you using PHP7 in strict mode? Found this issue for Guzzle:

http_build_query( [], null, '&' );

produces a fatal error: Uncaught TypeError: http_build_query() expects parameter 2 to be string, null given

#4 @natostanco
8 years ago

hhvm.php7.all = 1

enforces this typecheck

#5 @desrosj
5 years ago

  • Keywords reporter-feedback removed
  • Resolution set to wontfix
  • Status changed from new to closed

Since this is an issue with HHVM, I am going to close this out. Support for HHVM was removed from WordPress in 2017.

Note: See TracTickets for help on using tickets.