a small fix for endless update nagging in latest hhvm

[natostanco]

On [php] => 7.0.99-hhvm
on this line the null parameter makes the http_build_query return null, causing the "please update!" message of doom, changing it to false solves it.

[netweb]

@natostanco Welcome to Trac and thanks for the creating the ticket :)

What version of HHVM are you using?

The latest version is 3.13.1 so I am trying to work out where 7.0.99-hhvm comes from

[natostanco]

I believe it was the php version reported by wp, maybe from phpinfo? when I tested this I was on hhvm 3.12 iirc

[ocean90]

@natostanco Are you using PHP7 in strict mode? Found this issue for Guzzle: ​https://github.com/guzzle/guzzle/issues/1366

<?php
declare(strict_types=1);
http_build_query( [], null, '&' );

produces a fatal error: Uncaught TypeError: http_build_query() expects parameter 2 to be string, null given

[natostanco]

hhvm.php7.all = 1

enforces this typecheck

[desrosj]

Since this is an issue with HHVM, I am going to close this out. ​Support for HHVM was removed from WordPress in 2017.