Custom logo: the image size argument is not taking in account

[imath]

In this ​post on Make.WP.org

you explain we can set/get the image size of the custom logo this way :

add_image_size( 'theme-prefix-logo', 400, 175 );
add_theme_support( 'custom-logo', array(
   'size' => 'theme-prefix-logo',
) );

Unfortunately it's not working anymore, the size argument is not kept in the add_theme_support() function. As a result, the full size is always output. It looks like adding the size arguments to the defaults one is fixing the issue.

See suggested patch, attached to this ticket.

[ocean90]

It seems like the make/core post isn't updated yet to reflect the changes in [37077].

[obenland]

I updated the post to reflect the new arguments and added a paragraph to explain the change:

[EDIT]: As of [37077], Custom Logo does not support the size argument anymore. Specifying the logo size in individual arguments has the advantage of only creating a special image file for the specific logo used (and not every image uploaded), and providing more parity with how Custom Header works.

[imath]

@obenland @ocean90

Fine, but then why using get_theme_support( 'custom-logo', 'size' ); in the function get_custom_logo() as it's not possible to specify this size with add_theme_support() anymore ??

see https://core.trac.wordpress.org/browser/trunk/src/wp-includes/general-template.php#L879

It seems weird to me to use a function that can't return anything set by the theme....

So to be consistent i think you should allow the size argument or remove this get_theme_support( 'custom-logo', 'size' ); part...

[ocean90]

36327.diff​ removes the $size reference from get_custom_logo().

[DrewAPicture]

36327.diff​ Looks good.

[obenland]

In 37135:

Template: Remove $size reference from get_custom_logo().

Argument was removed in [37077] in favor of with and height arguments.

Props ocean90.
Fixes #36327.