WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#36331 closed defect (bug) (fixed)

Update docblock for is_tax to indicate it's for custom taxonomies only

Reported by: themiked's profile theMikeD Owned by: drewapicture's profile DrewAPicture
Milestone: 4.6 Priority: normal
Severity: normal Version: 2.9
Component: Taxonomy Keywords: 4.6-early needs-patch
Focuses: docs Cc:

Description

We should add the info that is_tax is for custom taxonomies only now that devhub pulls its primary content direct from source.

Attachments (2)

36331.diff​ (715 bytes) - added by theMikeD 8 years ago.
Patch for 36331
36331.2.diff​ (1.3 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (11)

@theMikeD
8 years ago

Patch for 36331

@SergeyBiryukov
8 years ago

#1 @SergeyBiryukov
8 years ago

  • Component changed from Text Changes to Taxonomy
  • Keywords has-patch 3.6-early added
  • Milestone changed from Awaiting Review to Future Release

36331.2.diff​ also updates WP_Query::is_tax() docs.

#2 @SergeyBiryukov
8 years ago

  • Keywords 4.6-early added; 3.6-early removed

This ticket was mentioned in ​Slack in #meta-devhub by themiked. ​View the logs.
8 years ago

#4 @theMikeD
8 years ago

Missed that one. Thanks @SergeyBiryukov !

#5 @DrewAPicture
8 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)
  • Version changed from trunk to 2.9

#6 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37235:

Docs: Clarify that is_tax() and WP_Query::is_tax() return false for built-in taxonomies (category and tag archives).

Props theMikeD.
Fixes #36331.

#7 @SergeyBiryukov
8 years ago

  • Milestone changed from Future Release to 4.6

#8 @DrewAPicture
8 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

The false return condition info should be added directly to the return description for this function and method instead of in the DocBlock description.

#9 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37281:

Docs: Move the clarification of is_tax() and WP_Query::is_tax() return value added in [37235] to @return description.

Props DrewAPicture.
Fixes #36331.

Note: See TracTickets for help on using tickets.