Custom Logo: PHP warnings in add_theme_support

[obenland]

From the support forums: ​https://wordpress.org/support/topic/custom-logo-with-no-args-causing-php-warnings

Hi,

I'm testing the new WP4.5 development releases. Since current 4.5-RC1-37079 update I get these PHP warnings:

Warning: array_intersect_key(): Argument #1 is not an array in /srv/www/wordpress-default/wp-includes/theme.php on line 1570`

Warning: Cannot use a scalar value as an array in /srv/www/wordpress-default/wp-includes/theme.php on line 1570

Warning: Cannot use a scalar value as an array in /srv/www/wordpress-default/wp-includes/theme.php on line 1574

Warning: Cannot use a scalar value as an array in /srv/www/wordpress-default/wp-includes/theme.php on line 1575

I was able to trace these down to add_theme_support( 'custom-logo' );. When I use it in plain with no additional args, the PHP warnings above are thrown.

If I set custom logo with args, it works fine:

add_theme_support( 'custom-logo', array(
        'height'      => 160,
        'width'       => 160,
        'flex-height' => true,
        'flex-width'  => true,
) );

Is it required to set the args? Shouldn't it work without the args? What happens if no args are passed, will it take the full size of the uploaded image?

Thanks for addressing this issue!

[obenland]

36332.diff​ solves this problem like custom-header and custom-background do a few lines below.

[ocean90]

36332.diff​ makes sense.

[jorbin]

In 37092:

Prevent PHP Warnings when using Custom Logo with no params

The parsing of defaults assumes that $args will be an array. This solves it for Custom Logo the same way it is solved for custom-header and custom-background.

Props obenland.
Fixes #36332.