WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #36335, comment 116


Ignore:
Timestamp:
08/29/2016 12:39:10 PM (4 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36335, comment 116

    v1 v2  
    22> This is the part that worries me, you say they shouldn't, I agree. But from experience, they will, they most definitely will.
    33
    4 I agree with @schlessera - I don't think it's a good idea to base code decisions in Core on how developers might misuse it. There's always ways that someone can mess up WordPress by doing things in a way that are not intended to be handled that way. Anything like that falls under the second type of error condition and should fatally fail if possible (so that they find out it's wrong during development) or be forbidden by guidelines like "Writing a Plugin" (where it is already stated that one shouldn't use a custom prefix for custom stuff).
     4I agree with @schlessera - I don't think it's a good idea to base code decisions in Core on how developers might misuse it. There's always ways that someone can mess up WordPress by doing things in a way that are not intended to be handled that way. Anything like that falls under the second type of error condition and should fatally fail if possible (so that they find out it's wrong during development) or be forbidden by guidelines like "Writing a Plugin" (where it is already stated that one should use a custom prefix for custom stuff).
    55
    66> Just look at 4.6 which had this with a single generically named function for `the_post_thumbnail_caption` which themes and plugins were already using, already declared function and classes means server error, this can't be fixed without accessing the file system in some way, which is a technical step many of our users are not comfortable making (and we shouldn't force upon them if we can avoid it).