WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #36335, comment 63


Ignore:
Timestamp:
08/25/2016 07:01:10 AM (4 years ago)
Author:
schlessera
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36335, comment 63

    v1 v2  
    1717> > xrstf\Composer52\Generator::onPostInstallCmd
    1818> }}}
    19 This is one example of bad class design in a third-party library. A quick search seems to indicate that the fix for this would completely contained within that third-party library, by renaming the two classes, and changing line 906 in `wp-admin/includes/class.ftp.php`.
     19This is one example of bad class design in a third-party library. A quick search seems to indicate that the fix for this would be completely contained within that third-party library, by renaming the two classes, and changing line 906 in `wp-admin/includes/class.ftp.php`.
    2020
    2121> 6) I'm not sure yet how I feel about automatically making so much of wp-admin available on everypage load.  In the past, core has forced developers to make a cognitive decision to include those pieces on the front end if they want to use them. Is that a change that should be made?  why?