Hiding the Title Attribute in the screen options of Menu page not working

[sidati]

Hi there,

On the screen options of Menus page, you cannot hide "Title Attribute" using screen options checkbox, after quick investigation, it seems the value of the field is not the same as field's class, so there is 2 ways to fix that, either change the value of the field to be title-attribute to just change the class attribute of the related p tag to be field-attr-title description description-wide

Regards,
Sidati

[ocean90]

Broken since [36908].

Changingtitle-attribute to attr-title in [36908] was probably wrong because it's breaking [32691] (the default setting) too.

cc: @westonruter, @afercia

[westonruter]

@sidati good catch. This fixes the issue. But to help ensure back-compat, I suggest we just add the class name as opposed to replacing the class name, in case any plugins are targeting it. See 36353.2.diff​.

[sidati]

@westonruter good thinking :)

[ocean90]

Changingtitle-attribute to attr-title in [36908] was probably wrong because it's breaking [32691] (the default setting) too.

[afercia]

I'm afraid I won't have so much time to look at this. Seems to me either solutions would be OK, as long as the field name is the same in the Menus screen and in the Customizer, unless I'm missing something.

[westonruter]

Replying to ocean90:

Changingtitle-attribute to attr-title in [36908] was probably wrong because it's breaking [32691] (the default setting) too.

I see. So in wp_nav_menu_manage_columns() you're saying that attr-title should be returned to title-attribute in that underlying function.

[westonruter]

@sidati how about 36353.3.diff​?

[sidati]

@westonruter, Just apply your patch and everything works great on both screens wp-admin/nav-menus.php and the customizer, you only forgot to update the rtl stylesheet :P

[westonruter]

@sidati Thanks! The RTL stylesheet will be automatically updated via the build script (via grunt rtlcss). You can see that there are no RTL CSS files in the src repo.

[sidati]

@westonruter, Sorry i've been using this repo : ​https://core.svn.wordpress.org/trunk/.

Anyway screens options are perfect now, thank you guys for your time

[westonruter]

@ocean90 how does this look to you?

[ocean90]

36353.4.patch​ looks good.

[DrewAPicture]

36353.4.patch​ looks good.

[westonruter]

In 37153:

Customize: Fix toggle of title attribute field visibility on nav menus admin page.

Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.