WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36366 closed defect (bug) (fixed)

Tooltip for new inline link toolbar doesn't get translated

Reported by: pixolin Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: Editor Keywords: has-patch commit
Focuses: ui, javascript, administration Cc:

Description

It seems to me, that the tooltip 'Apply' in editor.addButton( 'wp_link_apply', { tooltip: 'Apply', … } ); doesn't get translated when using WordPress (e.g.) in German.

Other Tooltips have a placeholder for the translation in file wp-includes/class-wp-editor.php (e.g. 'Link options' => __( 'Link options' ), in line 1047) but there doesn't seem to be any for the "Apply"-Tooltip?

Attachments (1)

36366.patch (871 bytes) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (5)

#1 @ocean90
4 years ago

  • Component changed from Toolbar to Editor
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.5

#2 @SergeyBiryukov
4 years ago

  • Keywords has-patch added; needs-patch removed

#3 @azaozz
4 years ago

  • Keywords commit added

Patch is good.

#4 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 37091:

Editor: Make the tooltip for the 'apply' button in the inline link dialog translatable.

Props SergeyBiryukov.
Fixes #36366.

Note: See TracTickets for help on using tickets.