WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#36369 new enhancement

esc_url(): strip leading whitespace characters

Reported by: toszcze Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.8
Component: Formatting Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

I to strip leading whitespace characters form the URL passed to esc_url() function.

At the moment if we pass an URL with leading spaces (or other whitespace characters) to esc_url(), it returns an empty string, even if the URL is correct.

Attachments (2)

36369.diff (459 bytes) - added by toszcze 2 years ago.
36369_test.diff (1011 bytes) - added by toszcze 2 years ago.
Unit test

Download all attachments as: .zip

Change History (6)

@toszcze
2 years ago

#1 @toszcze
2 years ago

  • Keywords has-patch added

#2 follow-up: @swissspidy
2 years ago

  • Keywords needs-unit-tests added

What about trailing whitespace?

#3 in reply to: ↑ 2 @toszcze
2 years ago

Trailing spaces are correctly replaced by %20. I don't know if there is any case when trailing spaces in an URL would be necessary, but personally I would leave them, because they are not causing any issues.

@toszcze
2 years ago

Unit test

#4 @johnbillion
2 years ago

  • Keywords has-unit-tests added; needs-unit-tests removed
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 4.4.2 to 2.8
Note: See TracTickets for help on using tickets.