WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#36371 closed defect (bug) (fixed)

Add "deprecated" to _wp_upload_dir_baseurl()

Reported by: azaozz Owned by: azaozz
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

This was part from the "big" patch on #34945 (that didn't make it), we still need to add it.

Attachments (1)

36371.patch (430 bytes) - added by azaozz 4 years ago.

Download all attachments as: .zip

Change History (9)

@azaozz
4 years ago

#1 @azaozz
4 years ago

  • Keywords has-patch added

#2 @joemcgill
4 years ago

  • Keywords commit added
  • Owner set to azaozz
  • Status changed from new to assigned

Good catch. The only use was replaced with wp_get_upload_dir() in r36569.

#3 @DrewAPicture
4 years ago

36371.patch looks good. Should we not list wp_get_upload_dir() as the alternative though? If so, we'll need to adjust the docs slightly, e.g.

<?php
/**
 * Returns the base URL of the uploads directory.
 *
 * @since 4.4.0
 * @access private
 * @deprecated 4.5.0 Use wp_get_upload_dir()
 * @see wp_get_upload_dir()
 *
 * @return string The base URL.
 */

#4 @mikeschroder
4 years ago

I'd really hoped we could remove this function entirely during the release, since it was only around for one release, always marked private and with an _, and not used by any plugins (minus RespImg feature plugin) in the repo.

Since we're in RC, I support this change, but maybe a new ticket to remove the function in 4.6 is warranted so it doesn't enter forever deprecated-land?

#5 @jorbin
4 years ago

I agree with @mikeschroder. Maybe also add to the docs that it will be removed in 4.6? Then it needs to be removed EARLY

#6 @azaozz
4 years ago

All sounds good. Made #36375 for 4.6.

#7 @azaozz
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37112:

Add deprecated notice and removal warning to _wp_upload_dir_baseurl().

Props DrewAPicture, azaozz.
Fixes #36371.

#8 @DrewAPicture
4 years ago

In 37114:

Docs: Ignore _wp_upload_dir_baseurl() from parsing for the Code Reference.

See #36371.

Note: See TracTickets for help on using tickets.