Add "deprecated" to _wp_upload_dir_baseurl()

[azaozz]

This was part from the "big" patch on #34945 (that didn't make it), we still need to add it.

[joemcgill]

Good catch. The only use was replaced with wp_get_upload_dir() in r36569.

[DrewAPicture]

36371.patch​ looks good. Should we not list wp_get_upload_dir() as the alternative though? If so, we'll need to adjust the docs slightly, e.g.

<?php
/**
 * Returns the base URL of the uploads directory.
 *
 * @since 4.4.0
 * @access private
 * @deprecated 4.5.0 Use wp_get_upload_dir()
 * @see wp_get_upload_dir()
 *
 * @return string The base URL.
 */

[kirasong]

I'd really hoped we could remove this function entirely during the release, since it was only around for one release, always marked private and with an _, and not used by any plugins (minus RespImg feature plugin) in the repo.

Since we're in RC, I support this change, but maybe a new ticket to remove the function in 4.6 is warranted so it doesn't enter forever deprecated-land?

[jorbin]

I agree with @mikeschroder. Maybe also add to the docs that it will be removed in 4.6? Then it needs to be removed EARLY

[azaozz]

All sounds good. Made #36375 for 4.6.

[azaozz]

In 37112:

Add deprecated notice and removal warning to _wp_upload_dir_baseurl().

Props DrewAPicture, azaozz.
Fixes #36371.

[DrewAPicture]

In 37114:

Docs: Ignore _wp_upload_dir_baseurl() from parsing for the Code Reference.

See #36371.