WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36392, comment 35


Ignore:
Timestamp:
04/09/2016 03:31:11 PM (4 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36392, comment 35

    initial v1  
    33> I got rid of the extra disable_concat property
    44
    5 Yep, `do_concat` can be reused for this. I mostly added another "toggle" as if it is local (at the top of `WP_Scripts::do_item()`) it will act as a "break" in concatenating. That would make it work as described above: concat scripts as usual, when there is a script with "before" or "after", output all already concatenated scripts, then output the current script with the extras, and after that continue concatenating. Something to try next release :)
     5Yep, `do_concat` can be reused for this. I mostly added another "toggle" as if it is local (at the top of `WP_Scripts::do_item()`) it will act as a "break" in concatenating. That would make it work as described above: concat scripts as usual, when there is a script with "before" or "after", output all already concatenated scripts, then output the current script with the extras, and after that continue concatenating. That was actually the initial patch, perhaps something to try next release :)
    66
    77> Since nobody seems to be in favor of reverting the feature...
    88
    9 I'm actually 51/49 for 36392.2.diff vs. reverting at the moment. That change may still bring regression(s) somewhere. Hoping more people will look, test, push it today.
     9I'm actually 51/49 for 36392.2.diff vs. reverting at the moment. That change may still bring regression(s) somewhere. Hoping today more people will look, test, push it, etc.