#36394 closed defect (bug) (fixed)
git-or-svn module assumes only one can be true
Reported by: | iseulde | Owned by: | iseulde |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 4.5 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
If both are true, it runs twice, running all the test twice at the same time and causes failures. We could allow the callback to be only run once, but better to fix upstream.
Attachments (5)
Change History (18)
#2
@
9 years ago
Rather than creating another ticket adding support for full repo SVN checkouts whilst we're at it would be great. I've got checkouts (used for alternate version testing etc) of WordPress (and bbPress and BuddyPress) using https://develop.svn.wordpress.org/
rather than https://develop.svn.wordpress.org/trunk
, as such the .svn
folder is up the directory tree one folder alongside the branches
, tags
, and trunk
folders.
netweb@MacBook ~/dev/develop.svn.wordpress.org $ ls total 0 drwxr-xr-x 6 netweb staff 204 Apr 2 13:56 . drwxr-xr-x 44 netweb staff 1.5K Mar 31 17:51 .. drwxr-xr-x 8 netweb staff 272 Nov 20 16:06 .svn drwxr-xr-x 28 netweb staff 952 Dec 15 19:39 branches drwxr-xr-x 154 netweb staff 5.2K Apr 2 13:59 tags drwxr-xr-x 18 netweb staff 612 Mar 26 00:34 trunk netweb@MacBook ~/dev/develop.svn.wordpress.org $ svn info Path: . Working Copy Root Path: /Users/netweb/dev/develop.svn.wordpress.org URL: https://develop.svn.wordpress.org Relative URL: ^/ Repository Root: https://develop.svn.wordpress.org Repository UUID: 602fd350-edb4-49c9-b593-d223f7449a82 Revision: 37154 Node Kind: directory Schedule: normal Last Changed Author: azaozz Last Changed Rev: 37154 Last Changed Date: 2016-04-02 08:12:18 +1100 (Sat, 02 Apr 2016)
#6
@
9 years ago
- Milestone changed from 4.5 to Future Release
I don't think this is worth changing for 4.5. Having both git and svn in a checkout seems like an edgecase to me, and not one that . The case of having a full svn checkout is uncommon, but also something that's not specifically supported by any of the other VC agnostic tools..
Was this reported upstream to git-or-svn?
As far as the patch itself, we can't use let
, arrow functions or many other es6 functions with node 0.12 or 0.10 so I can't even test to see if it works as expected.
Can solve it like this + cleaning up a bit.