Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#36398 closed enhancement (fixed)

Tests for override filter of load_textdomain

Reported by:	realloc	Owned by:	swissspidy
Priority:	normal	Milestone:	4.6
Component:	I18N	Version:
Severity:	normal	Keywords:	has-unit-tests has-patch commit
Cc:		Focuses:

Description

There is a filter inside the function load_textdomain that lets you bypass the standard way to load a mo-file. There was no coverage for the use of this filter.

Attachments (3)

36398.diff (1.7 KB ) - added by realloc 10 years ago.: Unit tests for override_load_textdomain
36398.2.diff (2.1 KB ) - added by realloc 10 years ago.: Improved version
36398.3.diff (2.7 KB ) - added by swissspidy 10 years ago.

Download all attachments as: .zip

Change History (10)

@realloc
10 years ago

Attachment 36398.diff added

Unit tests for override_load_textdomain

@realloc
10 years ago

Attachment 36398.2.diff added

Improved version

#1 @kirasong
10 years ago

Keywords has-unit-tests needs-testing has-patch added

Thanks for the patch! Marking it as such so that it can be reviewed.

#2 @chriscct7
10 years ago

Version trunk

This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.

10 years ago

#4 @ocean90
10 years ago

Milestone Awaiting Review → 4.6
Owner set to swissspidy
Status new → reviewing

@swissspidy
10 years ago

Attachment 36398.3.diff added

#5 @swissspidy
10 years ago

Keywords commit added; needs-testing removed

Cleaned up the patch a bit in 36398.3.diff and added another test.

#6 @swissspidy
10 years ago

Resolution → fixed
Status reviewing → closed

L10n: Add unit tests for the override_load_textdomain filter.

Fixes #36398.

#7 @swissspidy
10 years ago

Dangit, I totally missed giving the props, sorry @realloc! Your username was even already in the clipboard :-(

Note: See TracTickets for help on using tickets.

Download in other formats: