WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#36398 closed enhancement (fixed)

Tests for override filter of load_textdomain

Reported by: realloc Owned by: swissspidy
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-unit-tests has-patch commit
Focuses: Cc:
PR Number:

Description

There is a filter inside the function load_textdomain that lets you bypass the standard way to load a mo-file. There was no coverage for the use of this filter.

Attachments (3)

36398.diff (1.7 KB) - added by realloc 4 years ago.
Unit tests for override_load_textdomain
36398.2.diff (2.1 KB) - added by realloc 4 years ago.
Improved version
36398.3.diff (2.7 KB) - added by swissspidy 4 years ago.

Download all attachments as: .zip

Change History (10)

@realloc
4 years ago

Unit tests for override_load_textdomain

@realloc
4 years ago

Improved version

#1 @mikeschroder
4 years ago

  • Keywords has-unit-tests needs-testing has-patch added

Thanks for the patch! Marking it as such so that it can be reviewed.

#2 @chriscct7
4 years ago

  • Version trunk deleted

This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.


4 years ago

#4 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.6
  • Owner set to swissspidy
  • Status changed from new to reviewing

@swissspidy
4 years ago

#5 @swissspidy
4 years ago

  • Keywords commit added; needs-testing removed

Cleaned up the patch a bit in 36398.3.diff and added another test.

#6 @swissspidy
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37746:

L10n: Add unit tests for the override_load_textdomain filter.

Fixes #36398.

#7 @swissspidy
4 years ago

Dangit, I totally missed giving the props, sorry @realloc! Your username was even already in the clipboard :-(

Note: See TracTickets for help on using tickets.