WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #36406, comment 11


Ignore:
Timestamp:
07/11/2016 02:14:25 PM (3 years ago)
Author:
mensmaximus
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36406, comment 11

    v1 v2  
    33> Right now 3 is the default and 1 is possible if the `Network: true` header is set. I could see declaring `Network: false` as serving that purpose.
    44
    5 This is what the ticket is about and what the title says. $network_wide is not set consistently and therefore you cant rely on it. Please read my opening post again. You can exit the code after the ìf ($network_wide)` but you can't send a admin message to display a warning like "this plugin cant be activated networkwide". The problem stems from the error checking as explained in my comments 2, 3 and 6. The $network_wide argument passed to the plugin activation gets lost if the activation process raises an error.
     5This is what the ticket is about and what the title says. $network_wide is not set consistently and therefore you cant rely on it. Please read my opening post again. You can exit the code after the `if ($network_wide)` but you can't send a admin message to display a warning like "this plugin cant be activated networkwide". The problem stems from the error checking as explained in my comments 2, 3 and 6. The $network_wide argument passed to the plugin activation gets lost if the activation process raises an error.
    66